fix (\) SparseVector in SuiteSparse.CHOLMOD #28526
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasnoack
reviewed
Aug 8, 2018
stdlib/SuiteSparse/src/cholmod.jl
Outdated
| (\)(L::Factor, B::Sparse) = spsolve(CHOLMOD_A, L, B) | ||
| # When right hand side is sparse, we have to ensure that the rhs is not marked as symmetric. | ||
| (\)(L::Factor, B::SparseVecOrMat) = sparse(spsolve(CHOLMOD_A, L, Sparse(B, 0))) | ||
| (\)(L::Factor, B::SparseVecOrMat) = sparse(spsolve(CHOLMOD_A, L, Sparse(B))) |
Member
There was a problem hiding this comment.
It's not completely clear but the comment right above is the explanation for the zero so it is wrong to remove it here. Instead, I'd just split the method into one for matrices and one for vectors.
test for Factor and Symmetric Sparse Matrix
andreasnoack
approved these changes
Aug 8, 2018
Contributor
Author
|
Thanks so much for the comment. I also wrote a test for the symmetric matrix case. |
Member
Member
|
In case this gets successfully rebased on master, I'd suggest #34989 (review). |
ViralBShah
added a commit
that referenced
this pull request
Mar 5, 2020
* fix \ SparseVector * split (\) for sparsevector; test for Factor and Symmetric Sparse Matrix Co-authored-by: Chi Po Choi <[email protected]>
Member
|
I've merged #34989 |
Contributor
Author
|
Thank you so much! |
KristofferC
pushed a commit
that referenced
this pull request
Mar 23, 2020
* fix \ SparseVector * split (\) for sparsevector; test for Factor and Symmetric Sparse Matrix Co-authored-by: Chi Po Choi <[email protected]> (cherry picked from commit d2f9677)
27 tasks
ravibitsgoa
pushed a commit
to ravibitsgoa/julia
that referenced
this pull request
Apr 9, 2020
* fix \ SparseVector * split (\) for sparsevector; test for Factor and Symmetric Sparse Matrix Co-authored-by: Chi Po Choi <[email protected]>
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
* fix \ SparseVector * split (\) for sparsevector; test for Factor and Symmetric Sparse Matrix Co-authored-by: Chi Po Choi <[email protected]>
Moelf
added a commit
to Moelf/julia
that referenced
this pull request
Jun 10, 2020
This reverts commit d2f9677.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(\) for Factor and SparseVecOrMat has the following method error:
The method error is due to the call
Sparse(A::SparseMatrixCSC{Tv,SuiteSparse_long}, stype::Integer).It should call
Sparse(A::SparseVector{<:VTypes,SuiteSparse_long})andSparse(A::SparseMatrixCSC{<:VTypes,<:ITypes})instead.I fixed it and wrote a test: